[ObsOnboarding] Fix playwright tests#262525
Merged
diogolima-elastic merged 4 commits intoApr 13, 2026
Merged
Conversation
diogolima-elastic
added
release_note:skip
Contributor
ApprovabilityVerdict: Needs human review Test-only changes that fix Playwright e2e test selectors and remove unused locators, with no production runtime impact. However, all modified files are owned by @elastic/obs-onboarding-team and the author is not a designated owner, so the code owners should review. No code changes detected at You can customize Macroscope's approvability policy. Learn more. |
Contributor
💚 Build Succeeded
Metrics [docs]
|
michel-laterman
pushed a commit
to michel-laterman/kibana
that referenced
this pull request
Apr 13, 2026
## Summary PR elastic#257870 introduced a `checkPreExistingData` mechanism to the shared `DataIngestStatus` component that conditionally hides the `ProgressIndicator` when pre-existing data is detected but no new data has arrived yet. This broke the Ensemble nightly Playwright tests for the Kubernetes EA, OTel Kubernetes, and OTel Host onboarding flows, which were asserting the visibility of the progress indicator text ("We are monitoring your cluster" / "We are monitoring your host") as proof that data ingestion was detected. The fix updates each flow's page object to assert the "Explore logs" action link instead — an element that is always rendered once data (or pre-existing data) is detected, regardless of whether the progress indicator is shown or hidden.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #257870 introduced a
checkPreExistingDatamechanism to the sharedDataIngestStatuscomponent that conditionally hides theProgressIndicatorwhen pre-existing data is detected but no new data has arrived yet. This broke the Ensemble nightly Playwright tests for the Kubernetes EA, OTel Kubernetes, and OTel Host onboarding flows, which were asserting the visibility of the progress indicator text ("We are monitoring your cluster" / "We are monitoring your host") as proof that data ingestion was detected.The fix updates each flow's page object to assert the "Explore logs" action link instead — an element that is always rendered once data (or pre-existing data) is detected, regardless of whether the progress indicator is shown or hidden.